Repository navigation
fix(targeting): make hids optional in TargetingRequest - #388
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
antoinehakim-optable
approved these changes
Nov 12, 2026
mosherBT
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
TargetingRequestdeclaredhids(hint identifiers) as required, so TypeScript rejectedsdk.targeting({ ids: ["a"] })even thoughnormalizeTargetingRequestalready defaults a missinghidsto[]at runtime.What Changed
lib/edge/targeting.ts:hidsis nowhids?: string[], andTargeting()reads it withreq.hids?.forEach, so direct callers of the exportedTargeting()that omit it don't throw.lib/sdk.test.ts: the targeting test now checks thathidsare sent ashid(previously untested).How to Test
npx jest: all 703 tests pass.npx tsc --noEmit -p lib: a callsdk.targeting({ ids: ["a"] })fails to type-check before this change (Property 'hids' is missing) and passes after. Jest doesn't type-check and test files are excluded fromtsc, so this is checked withtscrather than a test.Tested
Docs updated — the README's TargetingRequest section will be updated in docs: align README and addon docs with the code #387 to match.
Notes
Non-breaking: the type only gets looser.
idsstays required.🤖 Generated with Claude Code